Fix crit not always being 0.33 crit per luk but 0.3 in some cases #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically when luk changed due to status effects such as Gloria and other cases, the crit difference was calculated via 0.3 crit per luk instead of 0.33. Also only adding the difference on top can result in edge cases where integer arithmetic will round down to less than one should get, to prevent this we remove the old luk from our current crit first and recalculate with the new luk. Verified in pre-re 11.2 and re 14.0
skyleo
added
type:bug
MishimaHaruna
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Always let 1 luk be 0.33 crit (meaning 3 luk = 1 crit) just like on officials.
Basically when luk changed due to status effects such as Gloria and other cases, the crit difference was calculated via 0.3 crit per luk instead of 0.33.
Also only adding the difference on top can result in edge cases where integer arithmetic will round down to less than one should get, to prevent this we remove the old luk from our current crit first and recalculate with the new luk.
Verified in pre-re 11.2 and re 14.0
Inspired by rathena/rathena#7938
Issues addressed: #3094